Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown strikethrough with double tildes #529

Open
pacien opened this issue Jul 30, 2019 · 12 comments
Open

Markdown strikethrough with double tildes #529

pacien opened this issue Jul 30, 2019 · 12 comments
Labels
A-Composer O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience T-Enhancement Z-Upstream

Comments

@pacien
Copy link

pacien commented Jul 30, 2019

Is your suggestion related to a problem? Please describe.

Markdown formatting should support strike-through with ~~.

Using HTML tags is both unintuitive and inconvenient. Friends coming from Discord or Github users now expect most Markdown formatting to work and are heavily frustrated by the partial support. We always get bitten by this small discrepancy and have to edit messages afterwards.

Describe the solution you'd like

Allow the use of ~~ to strike text through: ~~some text~~ should be rendered as some text.

Describe alternatives you've considered

HTML tags such as <del>, <s> and their closing counterparts are annoying to type in the middle of conversations. That's why we have Markdown instead of HTML or BBCode in the first place for italic and bold text.

Switching from Markdown to the formatting toolbar back and forth solely to strike text through is cumbersome too.

Additional context

The CommonMark library used by Riot doesn't support ~~ by default, but some extensions seem to exist to fill that gap.

Related issue: element-hq/element-web#9330

@turt2live
Copy link
Member

as you've noted in the issue, we use commonmark and this is a limitation of that. Will leave this open to track the request given this and 9330 aren't the first issues to complain about this...

@SaphireLattice
Copy link

Perhaps it would be a good idea to switch from CommonMark to a different Markdown parsing library that supports GitHub flavoured markdown, one of the most commonly used markdown variations?

@t3chguy
Copy link
Member

t3chguy commented Aug 4, 2019

@aaronraimist
Copy link

This doesn't need an old-composer label

@d-a-v
Copy link

d-a-v commented Sep 13, 2021

Only strikethrough(<del>strikethrough</del>) is supported by today's elements.io.

This is easy to type on a real keyboard, but not so much on a smartphone touchscreen.

For those who wish to follow this up, this might be the still-opened related issue from 2017 in the CommonMark repository.

@SimonBrandner SimonBrandner added the O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience label Feb 11, 2022
@nadonomy nadonomy changed the title Markdown strike-through Markdown strikethrough with double tildes / GitHub flavoured markdown spec Feb 11, 2022
@nadonomy
Copy link

Edited the title as I failed to find this issue via search (strikethrough doesn't have a hyphen, and I keyword stuffed a bit).

@t3chguy
Copy link
Member

t3chguy commented Feb 11, 2022

GFM has its own issue #330 and keyword stuffing works in comments too

@t3chguy t3chguy changed the title Markdown strikethrough with double tildes / GitHub flavoured markdown spec Markdown strikethrough with double tildes Feb 11, 2022
@t3chguy
Copy link
Member

t3chguy commented Feb 11, 2022

Also Github's strikethrough is single tilde test

@Abastro
Copy link

Abastro commented Mar 23, 2022

As this is not going to be fixed seeing current states, guess I should consider moving to other matrix client.
EDIT: just ditched matrix for good, it simply does not work.

@tmonz
Copy link

tmonz commented Aug 2, 2022

any news?

@t3chguy t3chguy transferred this issue from element-hq/element-web Aug 2, 2022
@ggPeti
Copy link

ggPeti commented Feb 24, 2024

Not even <del> works on Element Android. There is currently no way to write strikethrough text on Element Android.

@gabrc52
Copy link

gabrc52 commented Feb 25, 2024

Element Android includes a rich text editor so you could file an issue there instead, to add support for strikethrough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Composer O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience T-Enhancement Z-Upstream
Projects
None yet
Development

No branches or pull requests