Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression: breadcrumbs reset to empty after refresh #11420

Closed
uhoreg opened this issue Nov 18, 2019 · 2 comments · Fixed by matrix-org/matrix-react-sdk#3629
Closed

regression: breadcrumbs reset to empty after refresh #11420

uhoreg opened this issue Nov 18, 2019 · 2 comments · Fixed by matrix-org/matrix-react-sdk#3629
Assignees
@turt2live
Labels
T-Defect X-Regression

Comments

@uhoreg
Copy link
Member

uhoreg commented Nov 18, 2019

Looks like #8549 has regressed. When I refresh on riot.im/develop, it forgets what was in the breadcrumbs, and just displays empty circles.

Version information

  • Platform: web

For the web app:

  • Browser: Firefox 70.0.0.1
  • OS: Debian
  • URL: riot.im/develop
@turt2live turt2live self-assigned this Nov 18, 2019
@uhoreg
Copy link
Member Author

uhoreg commented Nov 18, 2019

I see this in my console whenever I switch rooms. May be related.

Unhandled rejection TypeError: _content4 is null
    setValue@https://riot.im/develop/bundles/c8bf9e52d52159727f83/bundle.js:188274:17
    setValue@https://riot.im/develop/bundles/c8bf9e52d52159727f83/bundle.js:188875:48
    _callee$@https://riot.im/develop/bundles/c8bf9e52d52159727f83/bundle.js:187094:71
    tryCatch@https://riot.im/develop/bundles/c8bf9e52d52159727f83/bundle.js:201315:40
    invoke@https://riot.im/develop/bundles/c8bf9e52d52159727f83/bundle.js:201549:30
    defineIteratorMethods/</prototype[method]@https://riot.im/develop/bundles/c8bf9e52d52159727f83/bundle.js:201367:21
From previous event:
    setValue@https://riot.im/develop/bundles/c8bf9e52d52159727f83/bundle.js:187112:29
    _appendRoomId@https://riot.im/develop/bundles/c8bf9e52d52159727f83/bundle.js:155488:41
    onAction@https://riot.im/develop/bundles/c8bf9e52d52159727f83/bundle.js:155335:26
    _invokeCallback@https://riot.im/develop/bundles/c8bf9e52d52159727f83/bundle.js:224418:24
    dispatch@https://riot.im/develop/bundles/c8bf9e52d52159727f83/bundle.js:224394:14 rageshake.js:62:8

turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Nov 18, 2019
@turt2live
Add a bit more safety around breadcrumbs
8d25952 
Fixes element-hq/element-web#11420
@turt2live turt2live mentioned this issue Nov 18, 2019
Merged
@turt2live
Copy link
Member

This regressed in matrix-org/matrix-react-sdk#3577

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
T-Defect X-Regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a bit more safety around breadcrumbs matrix-org/matrix-react-sdk
2 participants
@uhoreg @turt2live