Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to skip welcome page #12551

Closed
yesennes opened this issue Feb 27, 2020 · 8 comments
Closed

Option to skip welcome page #12551

yesennes opened this issue Feb 27, 2020 · 8 comments
Labels
A-Config A-UI-Customisation UIFeatures etc. for customising entire parts of the UI A-Welcome-Page T-Enhancement

Comments

@yesennes
Copy link

yesennes commented Feb 27, 2020

Is your suggestion related to a problem? Please describe.
I am setting up a private server and would like users to be able to log in as quickly as possible. I don't need a welcome page explaining what riot and matrix are.

Describe the solution you'd like
I would like a server wide config option that if true takes the user to the log in page whenever it would take them to the welcome page, i.e. whenever a unauthenticated users goes to the main page or any room's url, or logs out.

Describe alternatives you've considered
It would be sufficient to redirect unauthenticated users to the login page whenever they go to and address like #/home or #/roomid.

Additional context
Add any other context or screenshots about the feature request here.

@t3chguy
Copy link
Member

t3chguy commented Feb 27, 2020

the homepage can be already disabled in config.json

@yesennes
Copy link
Author

I am having trouble finding that option. I tried setting embeddedPages.welcomeUrl to "/#/login" and "login.html" but that gives me a couldn't load page error.

@t3chguy
Copy link
Member

t3chguy commented Feb 27, 2020

Null should do it.

@turt2live
Copy link
Member

There's not currently an option to skip the welcome page. You can change the welcome page content, but if you set the setting to null or something like that it will just default to the built-in page. Edit welcome.html to do a redirect in the meantime.

@yesennes
Copy link
Author

yesennes commented Mar 6, 2020

That works but causes awkward flashing. Scripts I write in the welcome page don't seem to run either. I can add a config option a make a merge request if you want.

@turt2live
Copy link
Member

I'd want to check with the product team and development team before recommending a PR on this, only because this particular area of the code is hard enough to maintain and another config option might make it worse/impossible.

@hex-m
Copy link

hex-m commented Sep 28, 2020

Edit welcome.html to do a redirect in the meantime.

How?

I tried putting a location.href = .. into welcome.html but as @yesennes already mentioned it's not loaded.

@MadLittleMods
Copy link
Contributor

This now exists as the embedded_pages.login_for_welcome option.

login_for_welcome: When true (default false), the app will use the login form as a welcome page instead of the welcome
page itself. This disables use of welcome_url and all welcome page functionality.

We used this on https://app.gitter.im/ and it works great!

@MadLittleMods MadLittleMods added A-Config A-UI-Customisation UIFeatures etc. for customising entire parts of the UI labels Feb 17, 2023
t3chguy pushed a commit that referenced this issue Oct 17, 2024
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Config A-UI-Customisation UIFeatures etc. for customising entire parts of the UI A-Welcome-Page T-Enhancement
Projects
None yet
Development

No branches or pull requests

6 participants