Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Login button is hidden if LeftPanel is collapsed in ILAG #4227

Closed
ara4n opened this issue Jun 7, 2017 · 3 comments
Closed

Login button is hidden if LeftPanel is collapsed in ILAG #4227

ara4n opened this issue Jun 7, 2017 · 3 comments
Assignees
@turt2live
Labels
P1 T-Defect

Comments

@ara4n
Copy link
Member

ara4n commented Jun 7, 2017

No description provided.

@ara4n
Copy link
Member Author

ara4n commented Jun 8, 2017

putting as P2 as it's fairly unusual to collapse LeftPanel, and you can always login via the SetMxIdDialog

@ara4n ara4n added P1 and removed P2 labels Sep 12, 2018
@ara4n
Copy link
Member Author

ara4n commented Sep 12, 2018

To fix this, please can we just jump to the solution from the redesign - it doesn't need to cosmetically look right, but the idea is to just chuck the login & register buttons in the messagecomposer space for this scenario (given we can't send messages when we're a guest)

@turt2live turt2live self-assigned this Oct 15, 2018
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Oct 15, 2018
@turt2live
Move the login box from the left sidebar to where the composer is
94aac62 
Fixes element-hq/element-web#4227

This includes removing the collapse button that isn't needed anymore.
@turt2live turt2live mentioned this issue Oct 15, 2018
Merged
@turt2live
Copy link
Member

Fixed by matrix-org/matrix-react-sdk#2219

@turt2live turt2live mentioned this issue Oct 29, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
P1 T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@turt2live @ara4n