Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin unread rooms only considers badges #7723

Closed
turt2live opened this issue Nov 20, 2018 · 3 comments
Closed

Pin unread rooms only considers badges #7723

turt2live opened this issue Nov 20, 2018 · 3 comments
Assignees
@turt2live
Labels
P1 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@turt2live
Copy link
Member

Rooms that are 'mentions only' do not cause unread badges, which means the room is not ordered correctly.
@turt2live turt2live self-assigned this Nov 20, 2018
@aaronraimist
Copy link
Collaborator

Relevant conversation: https://matrix.to/#/!DdJkzRliezrwpNebLk:matrix.org/$154177512316qJtnn:raim.ist?via=matrix.org&via=t2bot.io&via=riot.tenx.tech&via=meshspace.de

screen shot 2018-11-20 at 11 10 10 am

Should it be a third option or should the behavior of the "pin unread rooms" option be changed?

@turt2live
Copy link
Member Author

The conversation was actually https://matrix.to/#/!iNmaIQExDMeqdITdHH:matrix.org/$15427278634667ofZxl:maunium.net?via=matrix.org&via=disroot.org&via=chat.weho.st&via=bosmsg.de

It probably shouldn't have a third option, but the "pin unread rooms" should order unread-with-badges above unread.

@lampholder lampholder added T-Defect P1 S-Minor Impairs non-critical functionality or suitable workarounds exist labels Nov 23, 2018
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Dec 5, 2018
@turt2live
Fix pinning of rooms without badges
216fc64 
Fixes element-hq/element-web#7723

This adds consideration for rooms that are "mentions only" (or "unread-muted" as internally referenced).
@turt2live turt2live mentioned this issue Dec 5, 2018
Merged
@turt2live
Copy link
Member Author

Fixed by matrix-org/matrix-react-sdk#2330

@turt2live turt2live mentioned this issue Dec 10, 2018
Closed
@richvdh richvdh mentioned this issue Aug 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
P1 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@turt2live @lampholder @aaronraimist