Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incoming session verification support #3428

Merged
merged 10 commits into from
Oct 29, 2024

Conversation

stefanceriu
Copy link
Member

@stefanceriu stefanceriu commented Oct 18, 2024

Introduce support for receiving and interacting with incoming device verification requests:

  • adop new rust side ffi level session verification controller api
  • update the sessionVerificationControllerProxy state machine and available screens
  • introduce a new sessionVerificationControllerProxy actions publisher and hook it onto the UserSessionFlowCoordinator to display incoming requests
  • update overall verification designs and copy, introduce more previews

Relates to element-hq/element-meta/issues/2464, fixes #1227

Powered by matrix-org/matrix-rust-sdk#4153

Screen.Recording.2024-10-18.at.14.30.11.mov

@stefanceriu stefanceriu requested a review from a team as a code owner October 18, 2024 12:54
@stefanceriu stefanceriu requested review from pixlwave and removed request for a team October 18, 2024 12:54
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, can't wait to have this working 🙌

@stefanceriu stefanceriu force-pushed the stefan/incomingSessionVerification branch from abbabec to 5ae0a38 Compare October 29, 2024 08:26
Copy link

github-actions bot commented Oct 29, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 80de507

Copy link

codecov bot commented Oct 29, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
848 1 847 0
View the full list of 1 ❄️ flaky tests
PreviewTests test_joinRoomScreen()

Flake rate in main: 15.11% (Passed 118 times, Failed 21 times)

Stack Traces | 15.1s run time
failed - Snapshot "Unknown" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_joinRoomScreen-iPhone-16-pseudo.Unknown.png"
@+
"file:.../tmp/PreviewTests/test_joinRoomScreen-iPhone-16-pseudo.Unknown.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.95932007 is less than required 1.0
The lowest perceptual color precision 0.39937502 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

…s only when on the initial incoming request acceptance stage.
@stefanceriu stefanceriu added the pr-feature for a new feature label Oct 29, 2024
@stefanceriu stefanceriu force-pushed the stefan/incomingSessionVerification branch from cb5a39d to 7c5e321 Compare October 29, 2024 11:12
@stefanceriu stefanceriu force-pushed the stefan/incomingSessionVerification branch from 7c5e321 to 5df98e9 Compare October 29, 2024 12:27
@stefanceriu stefanceriu force-pushed the stefan/incomingSessionVerification branch from 5df98e9 to 80de507 Compare October 29, 2024 13:20
@stefanceriu stefanceriu merged commit d77bb93 into develop Oct 29, 2024
4 of 5 checks passed
@stefanceriu stefanceriu deleted the stefan/incomingSessionVerification branch October 29, 2024 13:21
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verification Request from other devices
3 participants