-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incoming session verification support #3428
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me, can't wait to have this working 🙌
...ources/Screens/Onboarding/SessionVerificationScreen/SessionVerificationScreenViewModel.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Services/SessionVerification/SessionVerificationControllerProxy.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Services/SessionVerification/SessionVerificationControllerProxy.swift
Outdated
Show resolved
Hide resolved
...tX/Sources/Screens/Onboarding/SessionVerificationScreen/View/SessionVerificationScreen.swift
Show resolved
Hide resolved
...tX/Sources/Screens/Onboarding/SessionVerificationScreen/View/SessionVerificationScreen.swift
Outdated
Show resolved
Hide resolved
...tX/Sources/Screens/Onboarding/SessionVerificationScreen/View/SessionVerificationScreen.swift
Outdated
Show resolved
Hide resolved
… session verification requests.
…tead of percolating the SDK one.
abbabec
to
5ae0a38
Compare
Generated by 🚫 Danger Swift against 80de507 |
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky tests
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
…s only when on the initial incoming request acceptance stage.
cb5a39d
to
7c5e321
Compare
7c5e321
to
5df98e9
Compare
5df98e9
to
80de507
Compare
|
Introduce support for receiving and interacting with incoming device verification requests:
Relates to element-hq/element-meta/issues/2464, fixes #1227
Powered by matrix-org/matrix-rust-sdk#4153
Screen.Recording.2024-10-18.at.14.30.11.mov