Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config option turn_shared_secret_path #17690

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

V02460
Copy link
Contributor

@V02460 V02460 commented Sep 10, 2024

Add the config option turn_shared_secret_path and accompanying docs. The config allows Synapse to read the TURN shared secret from a file. The code was shamelessly adapted from the implementation of registration_shared_secret_path.

Reading secrets from files has the security advantage of separating the secrets from the config. It also simplifies secrets management in Kubernetes.

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

@V02460 V02460 requested a review from a team as a code owner September 10, 2024 16:33
@github-actions github-actions bot deployed to PR Documentation Preview September 10, 2024 16:34 Active
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

(This will also be useful to NixOS users 😊)

docs/usage/configuration/config_documentation.md Outdated Show resolved Hide resolved
@anoadragon453 anoadragon453 enabled auto-merge (squash) September 10, 2024 17:05
@github-actions github-actions bot deployed to PR Documentation Preview September 10, 2024 17:06 Active
@anoadragon453 anoadragon453 merged commit e06e3c4 into element-hq:develop Sep 10, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants