Fix bug when rejecting withdrew invite with a third_party_rules module #17930
+6
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rejecting a withdrew invite through federation, an out of band event needs to be created.
When doing so with a third_party_rules module installed,
get_prev_state_ids
is called on the context to calculate the state to pass atcheck_event_allowed
callbacks.The context for outliers is defined here, and
state_group_before_event
is None.This change makes the behavior of
get_prev_state_ids
andget_current_state_ids
match the one presented in the docstring regarding null state_group.Pull Request Checklist
(run the linters)