Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add appdata #25

Merged
merged 10 commits into from
Nov 24, 2020
Merged

Add appdata #25

merged 10 commits into from
Nov 24, 2020
+45 −1

Conversation

meisenzahl
Copy link
Member

Closes #23

jeremypw
jeremypw requested changes Nov 14, 2020
View reviewed changes
Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This follows the pattern of other wingpanel indicators so I guess it is generally OK. Just a couple of minor comments.

data/privacy.appdata.xml.in Outdated Show resolved Hide resolved
data/privacy.appdata.xml.in Outdated Show resolved Hide resolved
jeremypw
jeremypw approved these changes Nov 15, 2020
View reviewed changes
Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ryonakano
ryonakano requested changes Nov 15, 2020
View reviewed changes
data/meson.build Show resolved Hide resolved
@meisenzahl meisenzahl requested a review from ryonakano November 16, 2020 19:28
@ryonakano ryonakano mentioned this pull request Nov 16, 2020
Merged
@ryonakano
Copy link
Member

@meisenzahl I feel .pot and .po files should be generated automatically by Gettext Actions to keep the PR simple. The Gettext Actions is not yet set up for this repo so I made a PR (#26).

@meisenzahl
Copy link
Member Author

@ryonakano I removed extra translation files and merged master. But the CI fails because of missing translation files. Am I doing something wrong?

danirabbit
danirabbit requested changes Nov 17, 2020
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think CI will necessarily fail as long as what is in LINGUAS is not available. Theoretically, weblate should update LINGUAS also, so it should be possible to leave it blank

Left a couple of comments related to meson

po/extra/meson.build Outdated Show resolved Hide resolved
po/meson.build Outdated Show resolved Hide resolved
@meisenzahl
Copy link
Member Author

So few changes and yet so many people who had to help...

Thanks a lot folks!

ryonakano
ryonakano approved these changes Nov 24, 2020
View reviewed changes
Copy link
Member

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ryonakano ryonakano requested a review from danirabbit November 24, 2020 23:20
@danirabbit danirabbit merged commit b59822a into master Nov 24, 2020
@danirabbit danirabbit deleted the add-appdata branch November 24, 2020 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danirabbit danirabbit danirabbit approved these changes

@jeremypw jeremypw jeremypw approved these changes

@ryonakano ryonakano ryonakano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add appdata
4 participants
@meisenzahl @ryonakano @danirabbit @jeremypw