Whitelist feature #126
Open
Whitelist feature #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm missing some documentation/comments on what this feature exactly does and why it is needed? |
JCombee
requested changes
Jan 23, 2025
src/Helper/Whitelist.php
Outdated
| private readonly ScopeConfigInterface $scopeConfig, | ||
| private readonly StoreManagerInterface $storeManager | ||
| ) { | ||
| $this->contentTypes = explode(',', $this->scopeConfig->getValue( |
There was a problem hiding this comment.
The loading of these configuration lives in the src/Model/Configuration.php
It's about the issue below for which we need the feature. I have also updated the comments in the Pull Request. https://gitlab.elgentos.nl/dutchlabelshop/magento2/-/issues/2806 |
JCombee
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Webshops using Prismic expose many content through the direct page controller by type. This creates an endpoint that is publicly accessible, even when it doesn’t need to be. To address this, we should implement a filter to control which document types are exposed externally.
added extra config options:
By default, this feature is disabled.