Skip to content

Commit

Permalink
Fix system-test on non-POSIX paths
Browse files Browse the repository at this point in the history
* Properly add `tls`, `net` and `http2` node modules to the exclusion
  list for the `system-test` webpack build.

* Replace hard-coded slashes (`/`) with either slashes or backslashes
  in the module exclusion rules for the `system-test` webpack build.

Partially addresses googleapis#327.
  • Loading branch information
elierotenberg committed Sep 29, 2020
1 parent 3219c11 commit 5625cb2
Showing 1 changed file with 8 additions and 6 deletions.
14 changes: 8 additions & 6 deletions system-test/fixtures/kitchen/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,30 +28,32 @@ module.exports = {
},
node: {
child_process: 'empty',
fs: 'empty',
crypto: 'empty',
fs: 'empty',
http2: 'empty',
net: 'empty',
tls: 'empty',
},
module: {
rules: [
{
test: /src\/http2/,
test: /src(\/|\\)http2/,
use: 'null-loader',
},
{
test: /node_modules\/https-proxy-agent\//,
test: /node_modules(\/|\\)https-proxy-agent(\/|\\)/,
use: 'null-loader',
},
{
test: /node_modules\/gtoken\//,
test: /node_modules(\/|\\)gtoken(\/|\\)/,
use: 'null-loader',
},
{
test: /node_modules\/pkginfo\//,
test: /node_modules(\/|\\)pkginfo(\/|\\)/,
use: 'null-loader',
},
{
test: /node_modules\/semver\//,
test: /node_modules(\/|\\)semver(\/|\\)/,
use: 'null-loader',
},
{
Expand Down

0 comments on commit 5625cb2

Please sign in to comment.