Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better concat_rows error messages #1057

Merged
merged 7 commits into from
Jan 19, 2025

Conversation

billylanchantin
Copy link
Member

Fixes: #1023

Example:

df0 = DF.new([x: [1, 2, 3], y: ["g", "h", nil]])
df1 = DF.new([z: [4, 5, 6]])
DF.concat_rows(df0, df1)
dataframes must have the same columns

* dataframe 0 has these columns not present in dataframe 1:

    ["x", "y"]

* dataframe 1 has these columns not present in dataframe 0:

    ["z"]

@billylanchantin
Copy link
Member Author

@josevalim I'm aiming to emulate the new type error messages in Elixir with the indentations and newlines. If you would, please review with that in mind.

We can maybe skip the ANSI colors though since that'd be a big departure from our other error messages.

Copy link
Member

@josevalim josevalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!

@billylanchantin billylanchantin merged commit 29d7b36 into main Jan 19, 2025
3 checks passed
@billylanchantin billylanchantin deleted the bl-better-concat-rows-error-msg branch January 19, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide more details in error message around concat_rows
2 participants