Avoid unwanted showing/hiding of search bar on mobile when scrolling #1914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes elixir-lang#1913 Also stops the search bar from appearing when a fragment identifier link is loaded, preventing the obscuring of content of linked-to sections.
|
@DavidOliver yes, we don't know to show it on anchors. As long as the sidebar shows up when scrolling up, it is fine to remove it. |
|
@josevalim, thanks. The search bar is still showing when scrolling up. |
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1913
Please note the removal of the code commented with "Add 'scroll-sticky' class when not at the top". This removal stops the search bar from appearing when a fragment identifier link is loaded, preventing the obscuring of content of linked-to sections, such as a heading. Is there any reason this code should stay?