Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Url fix in imagedescriptionservice #1696

Merged
merged 5 commits into from
Jan 2, 2025
Merged

Conversation

denizekiz
Copy link
Contributor

Relates to:

#1694

Risks

low

Background

openai url only support jpg, png, webp,gif

What does this PR do?

Provides url in format jpg, png, webp,gif

What kind of change is this?

Bug fixes (non-breaking change which fixes an issue)

Documentation changes needed?

Testing

Where should a reviewer start?

Detailed testing steps

pnpm build
pnpm start

Copy link
Collaborator

@monilpat monilpat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this please make this change and test thanks

packages/plugin-node/src/services/image.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@monilpat monilpat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@monilpat monilpat merged commit 9ea2449 into elizaOS:develop Jan 2, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants