Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: working farcaster client with neynar #570

Merged
merged 9 commits into from
Dec 7, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .env.example
Original file line number Diff line number Diff line change
Expand Up @@ -93,3 +93,8 @@ STARKNET_RPC_URL=

# Coinbase Commerce
COINBASE_COMMERCE_KEY=

# Farcaster Neynar Configuration
FARCASTER_FID=
FARCASTER_NEYNAR_SIGNER_UUID=
FARCASTER_NEYNAR_API_KEY=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sayangel Add comments for the newly added environment variables (FARCASTER_FID, FARCASTER_NEYNAR_SIGNER_UUID, FARCASTER_NEYNAR_API_KEY) to explain what each variable is used for and any format restrictions. This will help developers understand how to set up these configurations correctly.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw does neynar signer uuid is the client id?

1 change: 1 addition & 0 deletions agent/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
"@ai16z/client-auto": "workspace:*",
"@ai16z/client-direct": "workspace:*",
"@ai16z/client-discord": "workspace:*",
"@ai16z/client-farcaster": "workspace:*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sayangel Ensure that you review and update the documentation to reflect this new dependency.

"@ai16z/client-telegram": "workspace:*",
"@ai16z/client-twitter": "workspace:*",
"@ai16z/eliza": "workspace:*",
Expand Down
19 changes: 19 additions & 0 deletions packages/client-farcaster/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
{
"name": "@ai16z/client-farcaster",
"version": "0.0.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sayangel Review the new package’s version (0.0.1). Consider versioning best practices see semver.org

"main": "dist/index.js",
"type": "module",
"types": "dist/index.d.ts",
"dependencies": {
"@ai16z/eliza": "workspace:*",
"@neynar/nodejs-sdk": "^2.0.3",
"viem": "^2.21.47"
},
"devDependencies": {
"tsup": "^8.3.5"
},
"scripts": {
"build": "tsup --format esm --dts",
"dev": "tsup --watch"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sayangel add both the lint and test scripts, refer to other packages to get more details about their implementations.

}
}
Loading