feat: flow update generate object #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odilitime
reviewed
Dec 10, 2024
| let addressableCap = signer.capabilities.storage.issue<&EVM.CadenceOwnedAccount>(storagePath) | ||
| signer.capabilities.unpublish(publicPath) | ||
| signer.capabilities.publish(addressableCap, at: publicPath) | ||
| } |
There was a problem hiding this comment.
everything in this PR looks good but I don't feel qualified to review this portion
There was a problem hiding this comment.
Oh, it is Flow blockchain dedicated transaction optimization to avoid EVM coa resource is nil.
If we only look at the semantics and not the grammar, i think its intention is clear.
btspoony
force-pushed
the
tbh/flow-update-generateObject
branch
from
1c65758 to
9059d9c
Compare
odilitime
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
#920
Risks
Low
Background
What does this PR do?
What kind of change is this?
Improvements (misc. changes to existing features)
Why are we doing this? Any context or related work?
Only prompt tuning, flow transaction script optimization, and using
generateObjectArrayto replacegenerateObjectDEPRECATEDDocumentation changes needed?
None
Testing
Where should a reviewer start?
Detailed testing steps
None, automated tests are fine.
Discord username
bt.wood