fix(ui): Profile avatar image motion setting #3044

[AndrewCrescencio]

No description provided.

[netlify]

✅ Deploy Preview for elk-zone ready!

Name	Link
🔨 Latest commit	e02b2db
🔍 Latest deploy log	https://app.netlify.com/sites/elk-zone/deploys/6746db99bd56b60008100e21
😎 Deploy Preview	https://deploy-preview-3066--elk-zone.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[netlify]

✅ Deploy Preview for elk-docs canceled.

Name	Link
🔨 Latest commit	e02b2db
🔍 Latest deploy log	https://app.netlify.com/sites/elk-docs/deploys/6746db99d49031000848fe8c

[shuuji3]

Thanks for the contribution! I confirmed this change stopped gif animation by replacing static image like png when enabled prefers-reduced-motion setting.

[AndrewCrescencio]

nice, just commenting on it, I was a little worried, I don't know if at some point it might happen that the profile doesn't have a photo or doesn't have a static photo

[shuuji3]

Good point.

Mastodon has ensured avatar_static (https://docs.joinmastodon.org/entities/Account/#avatar) exists since v1.1.2 (in 2017), so I think we don't have to worry about that case, at least for Mastodon.

But the same property might not exist on other fediverse servers so it's safer to fall back to avatar property when there is no avatar_static. It's not optimal, but I think it's better than an empty image.

[shuuji3]

For example, something like this?

 const preferredMotion = usePreferredReducedMotion()
 const accountAvatarSrc = computed(() => {
-  return preferredMotion.value === 'reduce' ? account.avatarStatic : account.avatar
+  return preferredMotion.value === 'reduce' ? (account?.avatarStatic ?? account.avatar) : account.avatar

[shuuji3]

ref. GoToSocial returns static avatar like Mastodon: Routes and Methods - GoToSocial Documentation - https://docs.gotosocial.org/en/latest/api/swagger/

[AndrewCrescencio]

Yes, but idk if is really needed... thanks for docs link. I should also remove the structure props, because in the test log (issue #2934) is complaining about. I wanted to make the corrections, I don't know if I should make the changes to my fork and create the pull request here again...