Handle evil want keybinding #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jojojames
force-pushed
the
handle-evil-want-keybinding
branch
2 times, most recently
from
f8fb07c to
4ef3a64
Compare
Ambrevar
reviewed
Sep 12, 2018
| "Make sure to set `evil-want-keybinding' to nil before loading evil \ | ||
| or evil-collection.\ | ||
| \n | ||
| See https://github.com/emacs-evil/evil-collection/issues/60 for more details. ") |
There was a problem hiding this comment.
Spurious trailing space.
Also why the \? I think
or evil-collection.
See...
would be more readable.
There was a problem hiding this comment.
The formatting was better for me with that^.
|
Looks good to me! |
jojojames
force-pushed
the
handle-evil-want-keybinding
branch
from
4ef3a64 to
238938e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After is merged, we need to handle the latest changes.
emacs-evil/evil#1087
We should probably tag the last commit that still requires evil-want-integration to nil.
@Ambrevar