Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evil contrib repo #769

Closed
justbur opened this issue Feb 13, 2017 · 13 comments
Closed

evil contrib repo #769

justbur opened this issue Feb 13, 2017 · 13 comments
Labels

Comments

@justbur
Copy link
Member

justbur commented Feb 13, 2017

Hi, I think it would be nice to manage the various evil integration configurations in the emacs-evil organization. I saw this comment about unmaintained extensions and would like to add some of my own like evil-ediff and evil-magit to this list. I'm happy to contribute but would like others to chip in if possible.

There are existing configurations buried in evil-integration.el that I also thought could be broken out into separate files to make them more visible and more optional. I think it would also be nice to have some "official" extensions that would be easy for new people to find.

I don't have a strong opinion on how to organize things.

@wasamasa
Copy link
Member

Well, isn't Spacemacs basically the one and only Evil contrib repo you'd want to go for? No, I don't use it myself, otherwise I wouldn't suggest it.

As for breaking out the code, most of the integration code is really small and fixes up annoyances such as them being repeatable when they shouldn't. I don't really see the point in making users go through a backwards-incompatible change which amounts to them adding more require expressions to their code.

@ninrod
Copy link
Member

ninrod commented Feb 13, 2017

@justbur are you proposing like a curation of unmaintained evil packages? I'm all in for that.

@justbur
Copy link
Member Author

justbur commented Feb 14, 2017

Well, isn't Spacemacs basically the one and only Evil contrib repo you'd want to go for? No, I don't use it myself, otherwise I wouldn't suggest it.

I don't know what you mean. This doesn't have anything to do with spacemacs

@justbur are you proposing like a curation of unmaintained evil packages? I'm all in for that.

It has already been suggested that repos that are unmaintained could be brought under this organization. I think that's a good idea.

I was volunteering to add evil-ediff and evil-magit to this organization. These are stable and reasonably popular. Putting them here allows more people to look after them and also gives them more visibility. I thought eventually other evil-x packages that are popular and stable could be solicited and collected here for the same reason.

evil-ediff and evil-magit are just integration packages, but are somewhat more involved (and opinionated I guess) than the stuff in evil-integration.el. So I guess the distinction is valid.

@wasamasa
Copy link
Member

I don't know what you mean. This doesn't have anything to do with spacemacs

Well, Spacemacs is a collection of configuration (known as "layers") specially made to make Evil more integrated into Emacs for Vim refugees. As there is a significant community involved in those layers, it's basically a community repo for Evil-related configuration. My conclusion from this is that if you want integration going beyond Evil's basics, either write your own, install packages or use Spacemacs. There isn't much need for Evil to expand its integration efforts if other projects do so. Hosting relevant packages at our organization however would be fine.

@justbur
Copy link
Member Author

justbur commented Feb 14, 2017 via email

@ninrod
Copy link
Member

ninrod commented Feb 14, 2017

My conclusion from this is that if you want integration going beyond Evil's basics, either write your own, install packages or use Spacemacs.

Yes, many people go for install packages because, after a point, spacemacs is a hindrance to customization. And I'd like those packages to be mantained, ideally.

Some packages are a must have, even used by spacemacs and are abandoned. For example, evil-surround, which I mantain now, with near zero elisp knowlege. Not a pleasant state of affairs.

@TheBB
Copy link
Member

TheBB commented Feb 14, 2017

@justbur I have invited you to the organization (and this repo). Feel free to move your packages.

@ninrod Congratulations on taking over such a highly esteemed package! I'd be happy to move evil-surround here as well. Do we need Tim Charper's blessing first, perhaps?

@ninrod
Copy link
Member

ninrod commented Feb 14, 2017

@TheBB thank you. I surely will try to contact @timcharper about this.

It is certainly a core evil package. I mean tpope's plugin has like 4,4k stars. Using vim without vim-surround is a rare sight.

You gentleman may recall that a few months ago, the . operator on evil-surround suddenly started to break. I see the . operator as the sole reason for the package existence because I can always ciw''P for single quotes, for example. So this error cause me great lenghts of pain.

Now this was happening due to a regression that I've bissected here. This error was in production for almost 4 months. So now I need to write some tests, but I've never wrote an elisp test in my life.

Because of things like this, I see this curation initiative as a huge improvement in "fostering evil". We could write like a common testing framework, make sure that the curated packages don't brake in future versions of evil, etc...

@justbur
Copy link
Member Author

justbur commented Feb 14, 2017

@TheBB thanks. I just moved them. I'll send the update request to melpa for the recipes.

@wasamasa
Copy link
Member

@justbur Do you consider this resolved? If yes, please close this issue.

@justbur
Copy link
Member Author

justbur commented Feb 19, 2017

Yes I suppose

@justbur justbur closed this as completed Feb 19, 2017
@ninrod
Copy link
Member

ninrod commented May 1, 2017

@ninrod Congratulations on taking over such a highly esteemed package! I'd be happy to move evil-surround here as well. Do we need Tim Charper's blessing first, perhaps?

@TheBB, I just got the response back from @timcharper and he is cool with moving evil-surround to the emacs-evil organisation. Here's the email exchange:

Hi Filipe

Not sure why my email client decided to prematurely send. :/

Today is http://emaildebtforgiveness.me

I'd be totally willing to move the package.


Tim

On Tue, Feb 14, 2017 at 2:41 PM Filipe Silva <[email protected]> wrote:
Hi again Tim, 

You may know that evil now lives in a github organisation: http://github.com/emacs-evil/evil

An idea came about recently, about curating packages of the evil ecosystem here. And your evil-surround package was mentioned. 

Would you be willing to move the evil-surround package into the official evil organisation, where it could be fostered and supported by the community? 

Of course we would mantain all credits and copyright notices entitled to you. 

What do you think?

best regards,

ninrod, 

(github.com/ninrod)

What do you guys think. ping @wasamasa @justbur @syl20bnr

@wasamasa
Copy link
Member

wasamasa commented May 1, 2017

Sure, I'm fine with this, but would want more approval and let someone else do the migration, like @TheBB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants