Switch to using TCP mode instead of stdio #4622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcs090218
approved these changes
Nov 25, 2024
|
Can you fix the compile error? Thanks! |
TCP mode has proven to be more reliable than stdio and is required for container mode
dcermak
force-pushed
the
use-tcp-mode-for-rpm-spec
branch
from
6938876 to
fe9a4b4
Compare
Yes, should be done now. Sorry, I accidentally hardcoded port 50 🤦 |
|
I don't know why CI is still failing, but it should be resolved now. Merging this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TCP mode has proven to be more reliable than stdio and is required for container mode