Fix TypeScript compiler setup #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial approach with `tsc` being run during the `prepare` phases works when packages are delivered through a package manager. However, since the library is being installed via GitHub, that script is never run, hence the need for this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation 💪
This PR fixes a couple of small details that were overlooked when adding TypeScript support in #104, which led to the library v
1.18.0not being installable.Changes 🔧
This is the outcome of trying to install
v1.18.0in a TypeScript-powered project 🔴This is the result after the changes suggested by this PR ✅