Remove feature(impl_trait_projections) from async traits. #1872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dirbaio
force-pushed
the
remove-itp
branch
3 times, most recently
from
a0f297c to
db6d623
Compare
lulf
reviewed
Sep 11, 2023
|
bender run |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible
async_fn_in_traitswill get stabilized beforeimpl_trait_projections(see zulip thread).Trying out whether it's feasible to use
async_fn_in_traitsonly. Do not merge yet. Since it makes the code a bit uglier, we should only merge this if indeedasync_fn_in_traitsgets stabilized beforeimpl_trait_projections.EDIT: maybe
impl_trait_projectionsdoes get stabilized before AFIT: rust-lang/rust#115659