Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Exclude dist and tmp dirs from search in vscode #5643

Closed
wants to merge 1 commit into from
Closed

Conversation

Tyriar
Copy link

@Tyriar Tyriar commented Mar 20, 2016

Improve find in files in Visual Studio Code by excluding generated files in
a workspace config file.


Not sure if you accept editor-specific changes like this but I found ember-cli far more convenient with vscode when this was included after a little experimentation. (FYI I work on vscode)

image

I couldn't find any similar tests but let me know if you want one.

Improve find in files in Visual Studio Code by excluding generated files in
a workspace config file.
@stefanpenner
Copy link
Contributor

We don't currently provide editor specific configuration, rather such configuration should be provided be an addon. Otherwise we will end up generating a dozen set of such configurations speculatively.

Although I recognize the value, the cost of lots of unused files also quite high.

@Turbo87
Copy link
Member

Turbo87 commented Mar 20, 2016

I tend to agree. Creating such files should probably be the responsibility of vsc-ember-cli instead.

@Tyriar
Copy link
Author

Tyriar commented Mar 20, 2016

No worries, thanks for considering the change.

@Tyriar Tyriar closed this Mar 20, 2016
@stefanpenner
Copy link
Contributor

@Tyriar if you have an idea to allow us to bundle these helpful files, without eagerly polluting the users file trees, im all ears.

@Turbo87
Copy link
Member

Turbo87 commented Mar 20, 2016

something like an ember-cli-ide-files addon with blueprints for the major IDEs maybe?

@Tyriar
Copy link
Author

Tyriar commented Mar 20, 2016

The best thing may be to have vscode use the contents of .gitignore as part of search.exclude, that way this behavior would be the default.

@stefanpenner
Copy link
Contributor

@Tyriar yes totally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants