fix: ignore mirage directory for avoid-leaking-state-in-ember-objects #1004
+22
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsure if this is the right approach for mirage.. but I thought I'd see what others think 💭
This code in mirage..
..has the same issues as the similar code in ember that this rule is trying to prevent..
..but the consequences aren't as bad, as mirage isn't normally run in production.
Though there is still the risk of leaking state in tests?
Fixes #202
Fixes #214