Fix meta image #1647
Fix meta image #1647
Conversation
Resolves: #1621 Related to: ember-learn/ember-website#804
|
I copied the contents from https://github.com/ember-learn/ember-website/pull/804/files except for |
There was a problem hiding this comment.
@amyrlam Thanks for working on a solution. I checked that the image shows up when I post a Guides link in a tweet.
Before we merge the pull request, I'd like to see application tests added so that there's no regression in the future. Can we update the file https://github.com/ember-learn/guides-source/blob/master/tests/acceptance/meta-data-test.js in the following manner:
test('We set title and description correctly', async function(assert) {
// Navigate to Routing, Defining Your Routes
// Check title and description
// Navigate to Services, Overview
// Check title and description
});
test('We set metadata for Open Graph correctly', async function(assert) {
// Navigate to Routing, Defining Your Routes
// Check title, description, and image
// Navigate to Services, Overview
// Check title, description, and image
});
test('We set metadata for Twitter correctly', async function(assert) {
// Navigate to Routing, Defining Your Routes
// Check title, description, and image
// Navigate to Services, Overview
// Check title, description, and image
});You can use QUnit DOM to make assertions against elements in <head>. For example,
assert
.dom(document.querySelector('meta[name="twitter:title"]'))
.hasAttribute(
'content',
'Defining Your Routes - Routing - Ember Guides',
'We set the title correctly.'
);
assert
.dom(document.querySelector('meta[name="twitter:description"]'))
.hasAttribute(
'content',
/When your application starts, the router matches the current URL/,
'We set the description correctly.'
);
assert
.dom(document.querySelector('meta[name="twitter:image"]'))
.hasAttribute(
'content',
'https://blog.emberjs.com/images/logos/e-icon.png',
'We set the image correctly.'
);
app/index.html
Outdated
| @@ -3,7 +3,13 @@ | |||
| <head> | |||
| <meta charset="utf-8"> | |||
| <meta http-equiv="X-UA-Compatible" content="IE=edge"> | |||
| <meta name="description" content="Ember.js helps developers be more productive out of the box. Designed with developer ergonomics in mind, its friendly APIs help you get your job done—fast."> | |||
There was a problem hiding this comment.
This is applied by guidemaker so it shouldn't be hardcoded in here.
|
From the Learning Team meeting: This tests should be made in guidemaker, I just made a separate issue: empress/guidemaker#51 |
|
We reviewed this at the learning meeting and decided to move the PR forward after removing the description since it is applied by guidemaker. |
locks
dismissed
ijlee2’s stale review
learning team decided to upstream work a posteriori
Resolves: #1621
Related to: ember-learn/ember-website#804