Fix #1492 and fall back to serializing records into IDs when not embedded.

[kaukas]

In serializeHasMany the JSONSerializer was trying to serialize manyToNone relations (don't even know what that means) instead of manyToOne. I found @hg-schneider had already fixed that with a pull request pending (#1488). I used it as a base for my changes.

I had to modify other AMS integration tests to add empty arrays since hasMany is now serialized even when empty. Please review and confirm that this is correct and expected logic.

[tstirrat]

Could you also allow this functionality to run when embedded === 'load'

As I understand it, it seems to be the same logic.

[kaukas]

@tstirrat, the fix is for serialization. embedded: 'load' applies to extraction only, it does not affect serialization.

[tstirrat]

It is my understanding that embedded 'load' means to extract embedded, but
when saving (serializing), it will use _id and _ids.
On 28 Nov 2013 02:00, "kaukas" [email protected] wrote:

@tstirrat https://github.com/tstirrat, the fix is for serialization. embedded:
'load' applies to extraction only, it does not affect serialization.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1494#issuecomment-29451958
.

[kurko]

What this PR does is fixing a problem that I've seen too many people talk about lately. @kaukas could you take a look again at this? It'd be very good to have this PR merged imo.

[consideRatio]

Uncertain as i am, but i think...

[MartinElvar]

I would love to see a merge of this, what's the hold up? 🐹

[g-cassie]

+1

[stefanpenner]

@MartinElvar lack of time to review :(

[danielkywang]

+1

[Hammz]

Would be absolutely amazing to see this in release 1.0, this is ugently needed!

[leostera]

+1

[MartinElvar]

Here is a a quick fix for those of you who's in great need for a fix 😄

// Apply hack that fixes ManyToOne serialization.
// Use until this is merged, or fixed otherwise.
// https://github.com/emberjs/data/pull/1494
DS.ActiveModelSerializer.reopen({
  serializeHasMany : function(record, json, relationship) {
    var key = relationship.key;
    var relationshipType = DS.RelationshipChange.determineRelationshipType(record.constructor, relationship);

    if (relationshipType === 'manyToNone' || relationshipType === 'manyToMany' || relationshipType === 'manyToOne') {
      var payloadKey = this.keyForRelationship ? this.keyForRelationship(key, "hasMany") : key;
      json[payloadKey] = Ember.get(record, key).mapBy('id');
    }
  }
});

[quaertym]

👍

[edimoldovan]

Hi everyone!
Am I correct in thinking that this is not merged yet? If so, I would definitely buy at least beer to the team member who merges it :)
And, @MartinElvar thank you for the fix, it works like a charm!

[kalmanh]

+1 for @MartinElvar fix above

[igorT]

This was fixed with the merge of the better embedded records support thanks to @pixelhandler. You can now declare embedded: 'ids' in your attrs hash if you want to serialize the hasMany side.