Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] issue 9232 #9380

Draft
wants to merge 2 commits into
base: release-4-6
Choose a base branch
from
Draft

Conversation

Mikek2252
Copy link
Contributor

Description

Notes for the release

@runspired runspired added 🏷️ bug This PR primarily fixes a reported issue backport-old-release PR targets a previous non-lts release labels May 10, 2024
Copy link
Contributor

@runspired runspired left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a bit of cleanup and we should make sure to also PR this to main

@runspired runspired self-assigned this May 10, 2024
@@ -233,6 +233,9 @@ export default class RecordState {
notifications.subscribe(identity, (identifier: StableRecordIdentifier, type: NotificationType, key?: string) => {
switch (type) {
case 'state':
this.notify('isSaved');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@runspired what do you think is the best way to test this? Can try to write ones based of an existing one if you have an example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-old-release PR targets a previous non-lts release 🏷️ bug This PR primarily fixes a reported issue
Projects
Status: in progress
Development

Successfully merging this pull request may close these issues.

2 participants