Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: stub out linksMode work #9585

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

chore: stub out linksMode work #9585

wants to merge 21 commits into from
+1,687 −30

Conversation

runspired
Copy link
Contributor

Shipping "good enough" relationships to bring 5.4 to stable

Problem:

  • our long-term solution for relationships with SchemaRecord is for collections to be paginated, this requires an extensive lift to internals we have not yet had time to do.
  • our current solution for relationships is dependent upon Adapter/Serializer usage and has very complicated resolution rules that take multiple paths through the legacy infra depending on current state of loaded/partially/loaded/has-link etc.

Solution:

  • We can ship a non-legacy-mode version of belongsTo and hasMany schemas which only allow async behavior via links mode thereby enabling use of RequestManager without adapter/serializer support.
  • We can enable existing @ember-data/model instances to OPT-IN to this mode thereby removing their dependency on LegacyNetworkMiddleware

@runspired runspired added 🎯 canary PR is targeting canary (default) 🏷️ feat This PR introduces a new feature labels Oct 29, 2024
@gitKrystan gitKrystan force-pushed the feat-links-mode branch 3 times, most recently from 1f160e9 to d6b0bdc Compare November 8, 2024 00:54
gitKrystan
gitKrystan reviewed Nov 9, 2024
View reviewed changes
packages/store/src/-private/cache-handler/handler.ts
@@ -44,7 +44,7 @@ export type LooseStoreRequestInfo<T = unknown, RT = unknown> = Omit<
export type StoreRequestInput<T = unknown, RT = unknown> = ImmutableRequestInfo<T, RT> | LooseStoreRequestInfo<T, RT>;

export interface StoreRequestContext extends RequestContext {
request: ImmutableRequestInfo & { store: Store; [EnableHydration]?: boolean };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This moved up a level

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gitKrystan gitKrystan gitKrystan left review comments

Assignees
No one assigned
Labels
🎯 canary PR is targeting canary (default) 🏷️ feat This PR introduces a new feature
Projects
EmberData
Status: needs triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@runspired @gitKrystan