Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve module cycles so that ember-data 4.12 can work with Vite #9587

Draft
wants to merge 4 commits into
base: lts-4-12
Choose a base branch
from

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Nov 4, 2024

Description

under vite, importSync is the same as import, so we need to be careful about accidentally creating module cycles that would prevent a module from being evaluated by the browser.

Notes for the release

Add vite support for ember-data 4.12.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: needs triage
Development

Successfully merging this pull request may close these issues.

2 participants