Remove deprecated method and helper loc, drop support for ember-source < 3.20, upgrade dependencies, test under Embroider
#270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failure on 3.20 https://github.com/emberjs/ember-string/runs/3478006243#step:5:142 |
only run ember tests
|
To reproduce locally: |
Failing fast makes it difficult to diagnose the subset of the matrix that is failing beyond the first job that fails
Currently this is clearly suboptimal, once we learn more about TS in our projects. We can revisit ember-cli-typescript (or similar) to handle this for us automatically. Additionally, we plan embroider v2 to enable this “for free”
stefanpenner
force-pushed
the
kg-updates
branch
from
a6d1406 to
f7b141f
Compare
stefanpenner
force-pushed
the
kg-updates
branch
from
10436df to
7fbbd08
Compare
stefanpenner
force-pushed
the
kg-updates
branch
from
7fbbd08 to
3ce984b
Compare
|
Merging now – @kategengler will be handling the release (most likely tomorrow). |
kategengler
changed the title
loc, drop support for ember-source < 3.20, upgrade dependencies, test under Embroider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #269
Moves to a typescript setup copied from @ember/test-helpers