Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide debug utilities for inspector via event communication #20580

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

patricklx
Copy link
Contributor

@patricklx patricklx commented Nov 28, 2023

this would allow inspector to communicate with emberjs without relying on any globals like the define, require functions and without the barrel file.
it would be required for inspector to provide more functionality when using vite or also when building with embroider webpack and staticEmberSources=true

would also like to glimmerjs/glimmer-vm#1489
as part of this

emberjs/ember-inspector#2554

@kategengler
Copy link
Member

maybe @chancancode ?

@NullVoxPopuli
Copy link
Contributor

NullVoxPopuli commented Jun 11, 2024

We now need this to proceed with emberjs/rfcs#1015

For the VM side of this, glimmerjs/glimmer-vm#1489, benchmarks are running, so we'll know if this is safe.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this implementation is good for now, but we'll need to change things later, because I think we want ember-source to push panels into the inspector somehow.

needs some planning there, but it'd be great if ember-source's part of the inspector could be tested within ember-source, and than the inspector slurps those up (automatic updates depending on ember-source version!)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think pushing panels is not needed. more important would be to push a ember_debug directly from ember.js instead of having inspectors ember_debug try to support multiple versions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well the thinking here is that because ember.js is has more people working on it, it could be updated more easily than the inspector -- and then the inspector also doesn't need to maintain compatibility with everything going forward -- as it would be provided by ember-source

we should probs move to talking about this on the discord though -- lots of details to work through

we are saving pure values (string)
@patricklx patricklx changed the title proposal: provide debug utilities for inspector via event communication provide debug utilities for inspector via event communication Jun 11, 2024
@ef4
Copy link
Contributor

ef4 commented Jun 14, 2024

Are these things not already accessible via their existing private import paths?

@patricklx
Copy link
Contributor Author

Not with ember static source enabled. Then it's not accessible.

@patricklx
Copy link
Contributor Author

patricklx commented Jun 14, 2024

Biggest issue is the boot load event.
https://github.com/emberjs/ember.js/blob/main/packages/ember/barrel.ts#L749

And the whole ember source needs to be loaded before inspector can access it. (With AMD) There have been multiple issues around that in the past.

@patricklx
Copy link
Contributor Author

E.g. emberjs/ember-inspector#2051

As an example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants