Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rfc: ember-data | Deprecate Helper Functions #742

Merged
merged 2 commits into from
Apr 13, 2022
Merged

rfc: ember-data | Deprecate Helper Functions #742

merged 2 commits into from
Apr 13, 2022

Conversation

runspired
Copy link
Contributor

@runspired runspired commented Apr 24, 2021 •
edited
Loading

Full Text Rendered

@runspired runspired added T-ember-data RFCs that impact the ember-data library T-deprecation labels Apr 24, 2021
@runspired runspired mentioned this pull request Apr 24, 2021
Closed
snewcomer
snewcomer approved these changes Apr 30, 2021
View reviewed changes
Copy link
Contributor

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:nods

@igorT
Copy link
Member

igorT commented May 5, 2021

Seems 👍 but lets publish as a legacy util addon

@runspired runspired merged commit 58b95c4 into emberjs:master Apr 13, 2022
@runspired runspired deleted the ember-data/deprecate-helper-functions branch April 13, 2022 23:03
This was referenced Jul 28, 2022
Closed
Merged
@runspired runspired mentioned this pull request Sep 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kategengler kategengler kategengler left review comments

@snewcomer snewcomer snewcomer approved these changes

Assignees
No one assigned
Labels
Final Comment Period T-deprecation T-ember-data RFCs that impact the ember-data library
Projects
EmberData
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@runspired @igorT @kategengler @snewcomer