Watch previous detected files in publicEntrypoints plugin

[patricklx]

1. bug
   in public entrypoints we only add watch files. not dirs. When a file is removed, rollup also stops watching that file and ignores it if its re-created.
   We need to watch previous detected files.

2. Testing Bug
   Package.json is updated during the process which triggers a new build, we need to wait

Other things:
. Need to call result.close https://rollupjs.org/javascript-api/#rollup-watch
Not sure about nodejs/node#4760

[ef4]

The fix in public-entry points looks good.

The changes to the test waiting don't make sense to me. We're doubling down on time-based testing here when we should have none. If every single nextBuild() needs to be sandwiched between delays, then nextBuild is simply wrong.

The point of nextBuild is to observe rollup completing a full build. A delay before calling nextBuild makes no sense, because it's not supposed to matter. You can call it as early as you like and it will still wait until rollup decides to build again.

A delay after nextBuild would only be needed after rollup reports a build complete, we still can't observe its output on the filesystem. If we're sure that's happening, then we should build polling into nextBuild to account for that. But I am skeptical that is actually happening.

[ef4]

If anything, the possible race condition I see here would be calling nextBuild too late, not too early. Like, if you do fs.rm() and then your own process ends up slow enough that rollup finishes its build before you can initiate nextBuild, then your test might hang because you missed the build. But I also doubt this is happening, as the time scales involved in a direct filesystem mutation vs a whole rollup build are so different.

[patricklx]

the time delays are more for preventing chokidar from throttling and merging events that it thinks are atomic. but maybe those are not needed anymore

[patricklx]

If anything, the possible race condition I see here would be calling nextBuild too late, not too early. Like, if you do fs.rm() and then your own process ends up slow enough that rollup finishes its build before you can initiate nextBuild, then your test might hang because you missed the build. But I also doubt this is happening, as the time scales involved in a direct filesystem mutation vs a whole rollup build are so different.

okay, so that could then be related to the 150ms delay I introduced. But there was a delay before nextBuild already. so it could happen, but probably much less probability with 10ms.
with defer i mean the defer call on START event

[patricklx]

i get failures when i try again with 10ms

[patricklx]

logging start / end events it shows that we have 2 builds when we expect one. I suspect the update to package.json is triggering it.

> @embroider/[email protected] test D:\a\embroider\embroider\tests\scenarios
> qunit --require ts-node/register *-test.ts "--filter" "/v2-addon-dev-watch/"

TAP version 13
Test "deleting a component from src should delete it from dist" took longer than 3000ms, but no timeout was set. Set QUnit.config.testTimeout or call assert.timeout() to avoid a timeout in QUnit 3. https://qunitjs.com/api/config/testTimeout/
start
end
start
end
start
ok 1 v2-addon-dev-watch > Watching the addon via rollup -c -w > files are correctly synced > deleting a component from src should delete it from dist
end
not ok 2 v2-addon-dev-watch > Watching the addon via rollup -c -w > files are correctly synced > create a component in src should create it in dist
  ---
  message: "Expected D:\\temp\\tmp-5568BF4wsMXoBI26\\dist\\_app_\\components\\other.js to exist"
  severity: failed
  actual  : false
  expected: true
  stack: |
        at Object.<anonymous> (D:\a\embroider\embroider\tests\scenarios\v2-addon-dev-watch-test.ts:199:20)
  ...
start
end
ok 3 v2-addon-dev-watch > Watching the addon via rollup -c -w > files are correctly synced > updating hbs modifies generated colocated js
start
end
not ok 4 v2-addon-dev-watch > Watching the addon via rollup -c -w > files are correctly synced > deleting hbs file updates dist component file
  ---
  message: "Promise rejected during \"deleting hbs file updates dist component file\": Could not load D:\\temp\\tmp-5568BF4wsMXoBI26\\src\\components\\demo.hbs (imported by src/components/demo.js): ENOENT: no such file or directory, open 'D:\\temp\\tmp-5568BF4wsMXoBI26\\src\\components\\demo.hbs'"
  severity: failed
  stack: |
    Error: Could not load D:\temp\tmp-5568BF4wsMXoBI26\src\components\demo.hbs (imported by src/components/demo.js): ENOENT: no such file or directory, open 'D:\temp\tmp-5568BF4wsMXoBI26\src\components\demo.hbs'
        at async open (node:internal/fs/promises:639:25)
        at async Object.readFile (node:internal/fs/promises:1242:14)
        at async D:\a\embroider\embroider\node_modules\.pnpm\[email protected]\node_modules\rollup\dist\shared\rollup.js:25766:128
        at async Queue.work (D:\a\embroider\embroider\node_modules\.pnpm\[email protected]\node_modules\rollup\dist\shared\rollup.js:26145:32)
  ...
start
end
start
end
ok 5 v2-addon-dev-watch > Watching the addon via rollup -c -w > files are correctly synced > updating hbs content should not update unrelated files
start
end
ok 6 v2-addon-dev-watch > Watching the addon via rollup -c -w > files are correctly synced > updating hbs content should not update resulting app re-exported component
start
end
ok 7 v2-addon-dev-watch > Watching the addon via rollup -c -w > files are correctly synced > updating template only should update the dist output
start
end
ok 8 v2-addon-dev-watch > Watching the addon via rollup -c -w > files are correctly synced > deleting demo.js should make demo a template only component
start
end
ok 9 v2-addon-dev-watch > Watching the addon via rollup -c -w > files are correctly synced > creating demo.js should make demo a template colocated component
start
end
start
end
ok 10 v2-addon-dev-watch > Watching the addon via rollup -c -w > the package.json is not updated since it would be the same
start
end
start
end
start
end
ok 11 v2-addon-dev-watch > Watching the addon via rollup -c -w > the package.json *is* updated, since app-js changed
ok 12 v2-addon-dev-watch > the package.json *is* updated on a rebuild, since public assets changed

[patricklx]

@ef4 this is ready for another look. I updated the description with my new findings. I think i have figured out the real issues.
I leave the debug logs in so that you can see them in ci.

[patricklx]

ci run with extra debug logs https://github.com/embroider-build/embroider/actions/runs/12349262324/job/34459871601#step:5:1