Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use global variable in function, pass parameter instead. #269

Merged
merged 1 commit into from
Jun 1, 2021
Merged

Do not use global variable in function, pass parameter instead. #269

merged 1 commit into from
Jun 1, 2021

Conversation

goodpaperman
Copy link
Contributor

simple type mistake, only reproduct on macOS (?)
'optarg' is a global variable, can be used directly,
but macOS choked on that ,
and I see all other functions passing a parameter instead the global variable,
so here just add a function parameter.

Signed-off-by: yunh [email protected]

@emcrisostomo
Copy link
Owner

I can't reproduce it. However, I agree that we should not use the global variable there.

@emcrisostomo emcrisostomo merged commit 66a534e into emcrisostomo:master Jun 1, 2021
@emcrisostomo emcrisostomo changed the title fix compile error on macOS Do not use global variable in function, pass parameter instead. Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants