-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Errors in epaint update 0.30.0 related to profiling
#5491
Comments
Confirmed - I just tried updating and I am getting the same errors. I also tried cloning the repo instead of using the cargo.io release and the problem is still there. A bad merge, perhaps? |
I can reproduce this, but I'm not really sure why it would happen, it looks like it should be working 🤔 profiling = { version = "1", features = ["type-check"], default-features = false } @teddemunnik can you have a look at this? To reproduce this, the following cargo.toml has this problem for me: [package]
name = "egui_playground"
version = "0.1.0"
edition = "2021"
[dependencies]
eframe = "0.30.0"
egui = "0.30.0" |
Ah, it's because profiling::function_scope was added in profiling 1.0.16 and egui only has a dependency on 1.0, so we should update the profiling dependency to be >=1.0.16 So the proper way to fix this in your project is to run |
Ah my bad, sorry about that! Thank you for the quick fix @lucasmerlin |
Probably |
Summary: Added `egui` crate to fbsource vendoring. NOTE: I had to add the `profiling` crate because of emilk/egui#5491 Differential Revision: D68569632 fbshipit-source-id: 587a06ce744e3441de64c19b350606b3eee924f5
Summary: Added `egui` crate to fbsource vendoring. NOTE: I had to add the `profiling` crate because of emilk/egui#5491 Differential Revision: D68569632 fbshipit-source-id: 587a06ce744e3441de64c19b350606b3eee924f5
The text was updated successfully, but these errors were encountered: