Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement accessibility APIs via AccessKit #2294

Merged
merged 32 commits into from
Dec 4, 2022
Merged

Implement accessibility APIs via AccessKit #2294

merged 32 commits into from
Dec 4, 2022

Commits on Nov 29, 2022

  1. squash before rebase

    @mwcampbell
    mwcampbell committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    6483b45 View commit details
    Browse the repository at this point in the history

  2. Update AccessKit, introducing support for editable spinners on Window… 

    …s and an important fix for navigation order on macOS
    @mwcampbell
    mwcampbell committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    6dd2118 View commit details
    Browse the repository at this point in the history

  3. Restore support for increment and decrement actions in DragValue

    @mwcampbell
    mwcampbell committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    de62604 View commit details
    Browse the repository at this point in the history

  4. Avoid VoiceOver race condition bug

    @mwcampbell
    mwcampbell committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    a08282f View commit details
    Browse the repository at this point in the history

  5. fix clippy lint

    @mwcampbell
    mwcampbell committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    a472d14 View commit details
    Browse the repository at this point in the history

  6. Tell AccessKit that the default action for a text edit (equivalent to… 

    … a click) is to set the focus. This matters to some platform adapters.
    @mwcampbell
    mwcampbell committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    9e10822 View commit details
    Browse the repository at this point in the history

  7. Refactor InputState functions for AccessKit actions

    @mwcampbell
    mwcampbell committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    b65fd40 View commit details
    Browse the repository at this point in the history

  8. Support the AccessKit SetValue for DragValue; this is the only way fo… 

    …r a Windows AT to programmatically adjust the value
    @mwcampbell
    mwcampbell committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    599d147 View commit details
    Browse the repository at this point in the history

  9. Same for Slider

    @mwcampbell
    mwcampbell committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    a31d7dc View commit details
    Browse the repository at this point in the history

  10. Properly associate the slider label with both the slider and the drag… 

    … value
    @mwcampbell
    mwcampbell committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    9473dbd View commit details
    Browse the repository at this point in the history

  11. Lazily activate egui's AccessKit support

    @mwcampbell
    mwcampbell committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    2114978 View commit details
    Browse the repository at this point in the history

  12. fix clippy lint

    @mwcampbell
    mwcampbell committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    c47c3a1 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2022

  1. Update AccessKit

    @mwcampbell
    mwcampbell committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    884001f View commit details
    Browse the repository at this point in the history

  2. More documentation, particularly around lazy activation

    @mwcampbell
    mwcampbell committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    4282133 View commit details
    Browse the repository at this point in the history

  3. Tweak one of the doc comments

    @mwcampbell
    mwcampbell committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    c066889 View commit details
    Browse the repository at this point in the history

  4. See if I can get AccessKit exempted from the 'missing backticks' lint

    @mwcampbell
    mwcampbell committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    d14eab6 View commit details
    Browse the repository at this point in the history

  5. Make PlatformOutput::accesskit_update an Option

    @mwcampbell
    mwcampbell committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    3109ee9 View commit details
    Browse the repository at this point in the history

  6. Refactor lazy activation

    @mwcampbell
    mwcampbell committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    18ccf1f View commit details
    Browse the repository at this point in the history

  7. Refactor node mutation (again)

    @mwcampbell
    mwcampbell committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    49bbcf9 View commit details
    Browse the repository at this point in the history

  8. Eliminate the need for an explicit is_accesskit_active method, at lea… 

    …st for now
    @mwcampbell
    mwcampbell committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    7763ee0 View commit details
    Browse the repository at this point in the history

  9. Fix doc comment

    @mwcampbell
    mwcampbell committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    345b3c7 View commit details
    Browse the repository at this point in the history

  10. More refactoring of tree construction; don't depend on Arc::get_mut

    @mwcampbell
    mwcampbell committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    4a273c7 View commit details
    Browse the repository at this point in the history

  11. Override a clippy lint; I seem to have no other choice

    @mwcampbell
    mwcampbell committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    ae3a982 View commit details
    Browse the repository at this point in the history

  12. Final planned refactor: a more flexible approach to hierarchy

    @mwcampbell
    mwcampbell committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    87d3a90 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2022

  1. Last AccessKit update for this PR; includes an important macOS DPI fix

    @mwcampbell
    mwcampbell committed Dec 4, 2022
    Configuration menu
    Copy the full SHA
    f1908e2 View commit details
    Browse the repository at this point in the history

  2. Move and document the optional accesskit dependency

    @mwcampbell
    mwcampbell committed Dec 4, 2022
    Configuration menu
    Copy the full SHA
    9b71817 View commit details
    Browse the repository at this point in the history

  3. Fix comment typo 

    Co-authored-by: Emil Ernerfeldt <[email protected]>
    @emilk
    Matt Campbell and emilk authored Dec 4, 2022
    Configuration menu
    Copy the full SHA
    88840ef View commit details
    Browse the repository at this point in the history

  4. reformat

    @mwcampbell
    mwcampbell committed Dec 4, 2022
    Configuration menu
    Copy the full SHA
    0a6afeb View commit details
    Browse the repository at this point in the history

  5. More elegant code for conditionally creating a node 

    Co-authored-by: Emil Ernerfeldt <[email protected]>
    @emilk
    Matt Campbell and emilk authored Dec 4, 2022
    Configuration menu
    Copy the full SHA
    6d222c6 View commit details
    Browse the repository at this point in the history

  6. Set step to 1.0 for all integer sliders

    @mwcampbell
    mwcampbell committed Dec 4, 2022
    Configuration menu
    Copy the full SHA
    46e360b View commit details
    Browse the repository at this point in the history

  7. Add doc example for Response::labelled_by

    @mwcampbell
    mwcampbell committed Dec 4, 2022
    Configuration menu
    Copy the full SHA
    3077177 View commit details
    Browse the repository at this point in the history

  8. Clarify a TODO comment I left for myself

    @mwcampbell
    mwcampbell committed Dec 4, 2022
    Configuration menu
    Copy the full SHA
    e522a9b View commit details
    Browse the repository at this point in the history