Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report super/meta key for win/linux/web #4320

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

report super/meta key for win/linux/web #4320

wants to merge 5 commits into from

Conversation

psethwick
Copy link
Contributor

Re: #3653

Tested on linux (x11). I'm sort of trusting that winit/(other backends) handle the other platforms correctly.

this is a non-breaking change, I believe.

Alternatively (breaking) We could send meta on Mac, too? And then deprecate and eventually remove mac_cmd?

psethwick added 2 commits April 4, 2024 15:45
@psethwick
support for super key (win/linux)
ea8936f
@psethwick
rename super_ -> meta
b6fd03f 
reasoning:
- lose the underscore
- match the web platform name
@psethwick psethwick marked this pull request as ready for review April 4, 2024 18:49
emilk
emilk requested changes Apr 5, 2024
View reviewed changes
Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I think there are more places meta needs to be checked, like fn matches_logically

crates/egui-winit/src/lib.rs Outdated Show resolved Hide resolved
crates/egui/src/data/input.rs Outdated Show resolved Hide resolved
@rustbasic rustbasic mentioned this pull request Apr 7, 2024
Open
@psethwick psethwick requested a review from emilk April 8, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk Awaiting requested review from emilk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psethwick @emilk