-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tag 0.3? #59
Comments
v0.3.0 is tagged and also released on crates.io |
Hi, why did this bump semver? AFAICS there weren't any API incompatible changes? This crate is "between" some other major crates (like clap) and its main dependency of rustix. I'd like to avoid multiple copies of rustix in my dependency chain. Having semver bumps in this crate makes it much more likely that we have multiple rustix copies. |
xref clap-rs/clap#5129 |
Hi, there is a semver bump for two reasons:
I realize that both of these reasons are each pretty weak reasons to bump from v0.2 to 0.3, and so if you disagree with the version bump, I can definitely understand why. |
OK thanks, that is fair. For the first one, I'm personally in the camp that msrv bumps are not semver bumps, particularly because as of nowadays you can set
Fair enough, this is perhaps on the line for a semver bump IMO, but I understand it. Overall, a great thing about Rust is indeed the design of semver and being able to evolve library crates. I just feel we need to be mindful of the cost-benefit of doing so, as it necessarily implies work for downstream crate maintainers. |
Yeah, fully understood. In some cases, it's a balancing act: Don't update semver and risk breaking downstream crates (requiring them to manually pin some dependencies), or update semver and force downstream crates to updates dependencies to reduce duplications in the crate graph. I am very eagerly awaiting the day when cargo becomes MSRV-aware :) |
|
I didn't realize cargo had an initial implementation of this. Very cool! |
As of 3 weeks ago. See the tracking issue for where it falls short. |
cc eminence#59 This is the standard way to encode MSRV and in the future may be read by more tooling.
So then #60 |
cc eminence#59 This is the standard way to encode MSRV and in the future may be read by more tooling.
FYI, the subtle API change mentioned here made me ask for 0.3 here instead of 0.2.7. |
So that I can use the new features and dependencies rn.
The text was updated successfully, but these errors were encountered: