Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links to the original FaCT++ repo, GitHub profiles, etc. #600

Merged
merged 1 commit into from
May 9, 2023

Conversation

blokhin
Copy link
Contributor

@blokhin blokhin commented May 5, 2023

Description:

Add more info about FaCT++ reasoner

Type of change:

  • [ x] Documentation update.

@blokhin
Copy link
Contributor Author

blokhin commented May 5, 2023

@jesper-friis I believe, you mentioned exactly that during our meeting. Please, correct me, if I'm wrong.

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #600 (b6591be) into master (d52ddb4) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #600      +/-   ##
==========================================
+ Coverage   67.25%   67.28%   +0.03%     
==========================================
  Files          16       16              
  Lines        3127     3127              
==========================================
+ Hits         2103     2104       +1     
+ Misses       1024     1023       -1     

see 1 file with indirect coverage changes

@jesper-friis
Copy link
Collaborator

Thank you Evgeny. It would also be nice to have a link to your FaCT++ repo for later reference.

@francescalb francescalb merged commit ec3ff43 into emmo-repo:master May 9, 2023
@blokhin blokhin deleted the patch-2 branch May 10, 2023 21:31
@blokhin
Copy link
Contributor Author

blokhin commented May 12, 2023

@jesper-friis here it is https://github.com/tilde-lab/pyfactxx its obvious advantage over the current implementation is that the C++ kernel is directly used, and there is no need to invoke (and require) java APIs. I expect the replacement should not be complicated, since pyfactxx also provides the rdflib store.

@jesper-friis
Copy link
Collaborator

Thank you @blokhin. I added an issue on this: #603

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants