Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: kickoff repo #1
feat: kickoff repo #1
Changes from 1 commit
8555d8f
c5261e5
5a2da31
bbc978c
0bc49be
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost all Motive fronted project has:
why
format
and notprettier
?We should not stick to a tool name, in the future we could use another tool like Biome.
That is why we have
lint
and noteslint
.Check vs Fix
There are 2 options,
lint
only does checks and a long versionlint:fix
that fixes the issues.lint
fixes and long versionlint-check
checks.My proposal is, the short and quick/easy to write version, which is the one we usually use as developer, I would say with the fix included.
That is why I prefer option 2.
Also match with other scripts like
typecheck
ortype-check
"lint:inspect": "eslint . --inspect-config",
It is useful, but only occasionally, I think it will not be used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with
format
instead ofprettier
.I also refactored the script as you suggested, but with
lint:check
orformat:check
because it is as we use the scripts in every project.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"every project" → some