Remove EMIT_EMSCRIPTEN_METADATA settings #15319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
remove_emit_metadata
branch
2 times, most recently
from
8492391 to
0facc66
Compare
sbc100
changed the title
We have been warning about the deprecation of this setting for about a year now (since 2.0.9). As explained in #12231, the major use cases for this metadata are no longer valid since the embedder should on longer need to know the memory layout of the module (since the memory and table are both created and setup within the wasm module these days). Fixes: #12231
sbc100
force-pushed
the
remove_emit_metadata
branch
from
0facc66 to
9fe5470
Compare
kripken
approved these changes
Oct 18, 2021
Co-authored-by: Alon Zakai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been warning about the deprecation of this setting
for about a year now (since 2.0.9).
As explained in #12231, the major use cases for this metadata
are no longer valid since the embedder should on longer need to
know the memory layout of the module (since the memory and table
are both created and setup within the wasm module these days).
Fixes: #12231