Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle HALT properly #46

Closed
doegox opened this issue Oct 19, 2016 · 2 comments · Fixed by #50
Closed

Handle HALT properly #46

doegox opened this issue Oct 19, 2016 · 2 comments · Fixed by #50
Labels

Comments

@doegox
Copy link
Contributor

doegox commented Oct 19, 2016

Hi, I tried MF_ULTRALIGHT against a hotel door but it was highly unreliable.
The problem is that the emulation doesn't handle the STATE_HALT properly.
It should wake up only when receiving a WUPA and not when receiving a REQA otherwise the reader is discovering the same card over and over.

I tested it with an ugly patch, works better. I may provide a proper patch when having a bit more time...

@dev-zzo
Copy link
Contributor

dev-zzo commented Oct 19, 2016

True. This implementation of ISO 14443-3 Type A cards seems to differ from the standard for both Classic and Ultralight code... at least in two important aspects: a) accepting REQA/WUPA in any state and b) not differentiating between IDLE and HALT states.

@david-oswald Could you let us know the reasons behind this divergence from the standard? Should we submit patches to rectify this?

@geo-rg
Copy link
Collaborator

geo-rg commented Oct 19, 2016

You could submit patches. A good approach would be to change the ISO14443AWakeUp function or splitting it up in two functions that check for WUPA and REQA seperately. Also, the states inside the card emulation applications have to be changed.

So: If you find time to change this to the standard right now, you could submit a patch. But we also have this on our agenda, although this may need more time than if you do it.

ceres-c pushed a commit to ceres-c/ChameleonMini that referenced this issue Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants