Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiline response handling #105

Closed
wants to merge 1 commit into from
Closed

multiline response handling #105

wants to merge 1 commit into from

Conversation

geo-rg
Copy link
Collaborator

@geo-rg geo-rg commented Apr 5, 2017

This is a first approach to handle multiline responses from Chameleon properly. I first tried to send the EOT character but minicom printed it to screen which has been annoying.

This solution does the following: It sends a NULL-Byte right after a transmission has been finished (minicom ignores this). The chamtool now tries to obtain data until it reads a NULL-Byte. The latter one might look dangerous, but it should work as long as the firmware works. However, I'm not too familiar with efficient python, maybe someone knows how to handle this better?

Another idea would be to send this NULL-Byte before the final "\r\n", maybe this is better?

@geo-rg
Copy link
Collaborator Author

geo-rg commented Apr 5, 2017

I can already see a problem with the identify command. This first calls CommandLinePendingTaskFinished, which sends the NULL-Byte at its end, but then it adds some information (ATQA etc.), so chamtool would miss these additional information.

@geo-rg geo-rg closed this Sep 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant