Remove newlines from VERSION command. Fix for #16 #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The newlines from the VERSION command response are removed, as they differ from the specification of "101:OK WITH TEXT"
|
agreed, changing the firmware was out of my scope and abilities ;-) |
|
Thank you very much for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would propose this fix for #16 which removes the additional newlines in the response of the VERSION command.
The specification states for "101:OK WITH TEXT": "The command has been successfully executed and this response is appended with an additional line of information, terminated with CR+LF"
Maybe the formatting of this line could be improved, but this should so far fix the issue with the chamtool.
I would rather fix this in the way displayed here than to include an exception in the chamtool code, as proposed in #19.