feat: add from_reader_with_recursion_limit #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please re-word the commit message so the conventional commit checker passes: |
This change adds a from_reader_with_recursion_limit() variant of from_reader(), allowing the maximum recursion limit to be set explicitly. Fixes: enarx#58 which asks for the ability to set a higher recursion limit, but this is mainly intended for environments where the default limit of 256 is too large (i.e. the stack gets exhausted before the limit is hit). Signed-off-by: David Drysdale <[email protected]>
daviddrysdale
force-pushed
the
recurse-limit
branch
from
c6825a2 to
d6dc054
Compare
|
I couldn't get commisery to produce the same error locally (maybe I need some config file?) but I tried adding the colon suggested by the error – hope that helps. Thanks! |
rjzak
approved these changes
May 29, 2023
jrguzman-ms
pushed a commit
to msft-mirror-aosp/platform.external.rust.crates.ciborium
that referenced
this pull request
Jun 23, 2023
For Trusty we want to be able to reduce the recursion limit for CBOR
parsing, as the default is bigger than the normal stack limit in Trusty.
This change has been added upstream as commit 25174b7bc31f ("feat: add
from_reader_with_recursion_limit") from
enarx/ciborium#84, so it should be available in
the next release of ciborium.
Test: TreeHugger, local Trusty fuzzing build
Change-Id: Ie1ca9affc26927b2d83722b705d1e4c10200939f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a from_reader_with_recursion_limit() variant of from_reader(), allowing the maximum recursion limit to be set explicitly.
Fixes #58 which asks for the ability to set a higher recursion limit, but this is mainly intended for environments where the default limit of 256 is too large (i.e. the stack gets exhausted before the limit is hit).