Load and validate SGX quote #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Both haralds initial quote and the icelake quote validate, however the is_trusted function does not trust the icelake leaf certificate. |
npmccallum
reviewed
Mar 16, 2022
definitelynobody
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
|
@definitelynobody Please add |
|
@definitelynobody Also, can you submit the first commit as a separate PR so I can merge it immediately? I think we probably need to reorganize the commits so that they are logical and self-contained rather than stream of consciousness style. |
|
@bstrie Can you please take a review pass at this? |
Signed-off-by: Nicholas Farshidmehr <[email protected]>
|
pushed some fixes for the sgx changes |
|
@definitelynobody Merged with other fixes and full attestation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.