Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChoiceField defined with integer option values fails to indicate field state in HTML form output #4120

Closed
6 tasks done
arkadini opened this issue May 15, 2016 · 0 comments
Closed
6 tasks done

ChoiceField defined with integer option values fails to indicate field state in HTML form output #4120

arkadini opened this issue May 15, 2016 · 0 comments
Labels
Bug
Milestone
3.4.4 Release

Comments

@arkadini
Copy link

Checklist

  • I have verified that that issue exists against the master branch of Django REST framework.
  • I have searched for similar issues in both open and closed tickets and cannot find a duplicate.
  • This is not a usage question. (Those should be directed to the discussion group instead.)
  • This cannot be dealt with as a third party library. (We prefer new functionality to be in the form of third party libraries where possible.)
  • I have reduced the issue to the simplest possible case.
  • I have included a failing test as a pull request. (If you are unable to do so we can still accept the issue.)

Steps to reproduce

  • in a serializer, have a ChoiceField where choices' option values are integers
  • in the HTML form representation:
    • pick a valid choice for the field in question
    • submit

(see #4119 for an exact test case)

Expected behavior

The choice that was selected and submitted should be shown as selected choice in the HTML form field.

Actual behavior

The field in question never shows any currently set value.
arkadini added a commit to arkadini/django-rest-framework that referenced this issue May 15, 2016
@arkadini
Improve field value handling in HTML form output
dc0442c 
Let each form field's HTML template decide if it needs native or
string-ified field value, instead of forcing all templates to always
work only with unnecessarily restrictive string representation.

Fixes encode#4120, encode#4121
@arkadini arkadini mentioned this issue May 15, 2016
Closed
arkadini added a commit to arkadini/django-rest-framework that referenced this issue May 21, 2016
@arkadini
Improve HTML form rendering of choice fields
a6c5cc7 
Expose basic value on BoundField instances and use it to improve
rendering of choice fields in HTML form output.

Fixes encode#4120, encode#4121
@arkadini arkadini mentioned this issue May 21, 2016
Closed
@tomchristie tomchristie mentioned this issue Aug 10, 2016
Merged
@pyup-bot pyup-bot mentioned this issue Oct 22, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
3.4.4 Release
Development

No branches or pull requests
2 participants
@arkadini @tomchristie