-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up compat code #2200
Clean up compat code #2200
Conversation
You're going to need to remove (or edit) maryokhin@9621948, as right now it will close the ticket if we merge this. |
Yes, I'm rebasing now to clean up all the trash commits. |
This looks good to me. Is there more thing to add ? |
Neat. There will be a bunch of merge conflicts against the 3.1 branch but no biggie. |
Most moves of packages in Django and Python are handled by a dynamically loaded module |
Should be good to merge now. |
six.moves is well documented in the six's documentation. |
Thanks! |
I'm half way done, just wanted to put it up for public review. I'll add line comments on why it works without the compat code in the morning..