Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/tutorial 1 #2209

Merged
merged 2 commits into from
Dec 5, 2014
Merged

Bugfix/tutorial 1 #2209

merged 2 commits into from
Dec 5, 2014

Conversation

xordoquy
Copy link
Collaborator

@xordoquy xordoquy commented Dec 4, 2014

A few fixes to align the tutorial part 1 against drf v3.

@xordoquy xordoquy mentioned this pull request Dec 5, 2014
Closed
@carltongibson
Copy link
Collaborator

I had to check the 2.6 compat.

$ python -V
Python 2.6.9
$ python -c "print('Hello, World')"
Hello, World

Well, there you go... :)

Looks good.

carltongibson pushed a commit that referenced this pull request Dec 5, 2014
Merge pull request #2209 from linovia/bugfix/tutorial_1
e654287 
Bugfix/tutorial 1
@carltongibson carltongibson merged commit e654287 into encode:master Dec 5, 2014
tomchristie
tomchristie reviewed Dec 5, 2014
View reviewed changes
docs/tutorial/1-serialization.md
@@ -181,7 +181,7 @@ Deserialization is similar. First we parse a stream into Python native datatype
serializer = SnippetSerializer(data=data)
serializer.is_valid()
# True
serializer.object
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to demonstrate serializer.validated_data here.

@tomchristie
Copy link
Member

Nice work, opened #2214 for a very minor follow up.

@xordoquy
Copy link
Collaborator Author

xordoquy commented Dec 5, 2014

BTW, I'll submit later today a few changes for part 4 and 5 as well.
Took some time to run the full tutorial to make sure things are correctly aligned.

@carltongibson
Copy link
Collaborator

@xordoquy

Took some time to run the full tutorial to make sure things are correctly aligned.

Do you have the final code? — I'm updating the tutorial for encode/rest-framework-tutorial#16 but if you've got the finished product it might save a cycle or two if you could share the tar.

@xordoquy
Copy link
Collaborator Author

xordoquy commented Dec 5, 2014

@carltongibson busy with client work but I'll do it soon

@carltongibson
Copy link
Collaborator

@xordoquy No stress — if you get to it great; if not, I'm happy to work through the changes myself.

@xordoquy xordoquy deleted the bugfix/tutorial_1 branch December 6, 2014 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xordoquy @carltongibson @tomchristie