Fix set_rollback on @transaction.non_atomic_requests.

[hellysmile]

set_rollback()

checks only ATOMIC_REQUEST value, but it can be turned off per view by

@transaction.non_atomic_requests

Attempt to rollback without atomic block raises

raise TransactionManagementError("The rollback flag doesn't work outside of an 'atomic' block.")

https://github.com/django/django/blob/06dc6759d85c6c24b599de07cea47387d3dc2cf9/django/db/backends/base/base.py#L361

Really critical, due http404 for every @transaction.non_atomic_requests

[xordoquy]

Thanks for the pull request.
Will try to get it reviewed, merged and released today

[xordoquy]

The provided test is already working against the current master (without your fix being included).
I didn't investigate yet.

[hellysmile]

@xordoquy
Hmm, looks really strange

Here is runnig app
https://pull3016.herokuapp.com/

With this code
https://github.com/hellysmile/pull3016/blob/master/pull3016/urls.py#L28

[hellysmile]

Hey, factory.{HTTP_METHOD} do not triggers Django internal BaseHandler.get_response, which wraps views in transitions via BaseHandler.make_view_atomic.

In addition, django.test.TestCase wraps all database connection in atomic manually, django.test.TransactionTestCase must be used in this case.

@xordoquy can You try now without checking connection.in_atomic_block, it will definitely fails.

It was really hard to figure out this Django test internals...

[xordoquy]

@hellysmile ace !

[xordoquy]

Thanks for the PR !